Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): add built-in schemas #1788
feat(parser): add built-in schemas #1788
Changes from all commits
aa66d8c
64c3eb1
c5127f9
f0464ab
f353c7f
4a66dec
633ce9a
6078cb0
5bcab2e
0e9db61
fefe01a
c06989b
a4d3852
7a2a203
689ef45
7e0dd71
067fd82
04fd892
694f389
1408bb9
60b139b
1fdac46
f6d09d2
3f8f4bb
ccb51e1
208a66f
d8919d3
8eefbe8
eceea76
f67a8e1
955d277
f165302
06d5467
1af893a
a9cfa6a
2d671d0
7cdcc0b
dd39001
bd0cefe
7b33250
51219a8
bbf5ac3
d8a040f
254ebd7
e0dcf23
0b6d570
f453246
455b329
228217e
e330e51
8ce4af6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that both
headers
andqueryStringParameters
are marked asoptional
here, while in the Python implementation they're not.Is this to allow the multi value extension later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, once you turn on multi header, you can't pass headers, thus examples with multi-values break. pt-py did not test this case, or I could not find it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have looked into possible options and atm there is no straight forward way to have multiple mutually exclusive key/value pairs. It's not impossible, just needs more dedicated time to go through few options and pick the best.
I'd suggest to move forward as it is now and come back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema includes also multi value query string parameters, should we name this something more generic i.e.
AlbMultiValueSchema
(which I don't love) or something like it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The semantic link between the schema and the feature is in wording Multi-Value Header, thus I assume it's easier to connect the feature in the service and the schema values.
I'd suggest to keep it.