chore(csharp): update nodejs version to 20.x #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
force-pushed
the
csharp-nodejs-version
branch
from
075871a
to
92e85a7
Compare
|
I'm not sure why the The Node.js 20.x runtime was added in |
|
@trivikr It is your csproj file that controls the lib that your dotnet uses to compile. I removed your change to the csharp/package.json That file control the cdk cli version which I always want to be up to date. |
kaiz-io
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1010
Part of: #961
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.