Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Lambda Node.js to 20.x #1046

Closed
wants to merge 4 commits into from

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented May 30, 2024

Noticed in: #961

Node.js 20.x is the latest version of Lambda https://aws.amazon.com/blogs/compute/node-js-20-x-runtime-now-available-in-aws-lambda/


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kaiz-io
Copy link
Contributor

kaiz-io commented May 30, 2024

The tests failed make sure that you can run yarn run test or npm run --if-present test and that cdk synth works.

@kaiz-io kaiz-io added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label May 30, 2024
@trivikr
Copy link
Contributor Author

trivikr commented May 30, 2024

I'm not sure why the tests are failing. The yarn synth works locally for typescript/api-gateway-parallel-step-functions

Feel free to take over the PR, or close it.
The original goal for upgrading to Lambda Node.js 18.x is achieved, and this PR was just an additional update.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label May 31, 2024
@kaiz-io
Copy link
Contributor

kaiz-io commented Sep 17, 2024

So just fixed an issue that might have been affecting one error that you were getting. Currently the build is failing because in the project typescript/api-gateway-lambda-token-authorizer/ the test that is configured is failing because the snapshot is different.

Here is the command to run in the director to replicate the issue. npm run --if-present test

@kaiz-io kaiz-io added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Sep 17, 2024
Copy link

This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Sep 20, 2024
@github-actions github-actions bot closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants