Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case to verify utf8 support in object key #320

Closed
wants to merge 1 commit into from

Conversation

StaymanHou
Copy link

Follow-up PR for a previous PR #311 that's already resolved.

Add test case to verify it works now with object keys containing utf8 characters.

@StaymanHou StaymanHou changed the title Add test case for verify utf8 support in object key Add test case to verify utf8 support in object key Dec 28, 2021
@fisenkodv
Copy link
Contributor

Thank you for the PR. I have added this to our backlog queue.

@fisenkodv fisenkodv self-assigned this Jan 3, 2022
@fisenkodv fisenkodv self-requested a review January 10, 2022 18:35
@github-actions
Copy link

This pr has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the Stale label Dec 21, 2022
@github-actions
Copy link

This pr was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Dec 28, 2022
@dougtoppin dougtoppin reopened this Dec 28, 2022
@dougtoppin
Copy link
Contributor

This is still on our backlog to evaluate, and we will get to it. We appreciate your effort and submission.

@github-actions github-actions bot removed the Stale label Dec 29, 2022
@github-actions
Copy link

This pr has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the Stale label Mar 29, 2023
@dougtoppin dougtoppin removed the Stale label Mar 29, 2023
@dorrikh dorrikh assigned simonkrol and unassigned fisenkodv Oct 31, 2023
@simonkrol
Copy link
Member

simonkrol commented Feb 16, 2024

Hi @StaymanHou,

Thanks for your patience here, the change has been made internally and is set to be included in the next release. While our internal processes had us merge the code manually, once the release with this change is out, you'll see yourself included in the external contributors section towards the bottom of the readme and this PR will be closed.

Thanks for your contributions to Serverless Image Handler :)
Simon

@StaymanHou
Copy link
Author

Awesome! Thx for reviewing and merging the PR.

@simonkrol
Copy link
Member

Test case was included in v6.2.6, thanks for your contributions.

@simonkrol simonkrol closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants