feat(rewrite-pattern): multiple rewrite pattern and substitution support #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable style/lint
enable cdk nag
enable ql
enable unit tests
add file
testing develop branch workflow
quote branch names
Feature/399 multiple rewrite
|
This will require additions to the Implementation Guide listing the capability and providing example usages which will be submitted separately |
gsingh04
reviewed
Jan 4, 2023
| try { | ||
| return JSON.parse(str); | ||
| } catch (e) { | ||
| return [str]; |
gsingh04
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Contains enhanced changes from PR #399 where support added for multiple rewrite pattern and substitution entries.
REWRITE_MATCH_PATTERN and REWRITE_SUBSTITUTION values can be written like JSON Arrays.
So multiple rewrite rules can be applied.
For example;
REWRITE_MATCH_PATTERN:
["//thumb/g","//small/g","//large/g"]
REWRITE_SUBSTITUTION:
["/300x300/filters:quality(80)","/fit-in/600x600/filters:quality(80)","/fit-in/1200x1200/filters:quality(80)"]
Changes:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.