add JavaScript sdk #399
Merged
add JavaScript sdk #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svozza
force-pushed
the
create-sdk
branch
10 times, most recently
from
33a58c9
to
4073139
Compare
svozza
force-pushed
the
create-sdk
branch
6 times, most recently
from
afefd05
to
e911551
Compare
ConnorKirk
reviewed
Mar 28, 2023
Co-authored-by: Connor Kirkpatrick <[email protected]>
ConnorKirk
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Implements #11
Description of changes:
This PR implements the JavaScript API detailed in the following design doc. Of the choices outlined in this doc, we have chosen the following:
The package name
@aws/workload-discovery-sdkreferenced in the documentation is only a placeholder, we will change this to reflect the name and organization we ultimately choose to use when publishing to NPM.As the package has not been published to NPM yet, this means we are still free to make changes to how the SDK works so this may not be the final version that we eventually ship.