Change LocalAudioOutputProvider to not bind an audio element on startup when isAudioOn set is false #965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #964:
Description of changes:
Updated LocalAudioOutputProvider to check the value of isAudioOn when hooked on to
audioVideo
being initialized. It now won't bind the audio if it's already been disabled before startup.Testing
npm run build:release
locally?No - it immediately drops out with
Didn't find any new commit. Exiting process.
Guessing it's because I've already pushed to my fork? Wasn't mentioned in CONTRIBUTING.md so I didn't attempt to run it until creating the PR. Regular
npm run build
runs fine though.Unit tests rerun fine - no tests exist for this component, and not sure how to hook them up given the need to bind audio etc.
Tested locally by installing the dev version into our application. See issue for reproduction steps.
None made - should continue to operate as documented.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.