Remove the video tile mapping entry when video is removed instead of when video is unbound #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/amazon-chime-sdk-android#186
Description of changes:
Changed SDK behavior to remove the internal video tile mapping entry when video is removed, instead of when video is unbound. This provides better API symmetry so that the video metadata will be added in
videoTileDidAdd(tileState)
callback and removed invideoTileDidRemove(tileState)
callback.Testing done:
Tested by modifying the demo app so that it does not bind remote video in
videoTileDidAdd(tileState)
and it does not unbind remote video invideoTileDidRemove(tileState)
. Test steps:Manual test cases (add more as needed):
Screenshots, if available:
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.