Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the video tile mapping entry when video is removed instead of when video is unbound #179

Merged
merged 3 commits into from
Dec 7, 2020

Conversation

tianyux-amz
Copy link
Contributor

Issue #, if available:

aws/amazon-chime-sdk-android#186

Description of changes:

Changed SDK behavior to remove the internal video tile mapping entry when video is removed, instead of when video is unbound. This provides better API symmetry so that the video metadata will be added in videoTileDidAdd(tileState) callback and removed in videoTileDidRemove(tileState) callback.

Testing done:

Tested by modifying the demo app so that it does not bind remote video in videoTileDidAdd(tileState) and it does not unbind remote video in videoTileDidRemove(tileState). Test steps:

  1. UserA joined Web client and enabled video.
  2. UserB joined mobile client. Verified in the log that videoTileDidAdd was called for UserA's video, but the view was not bound (so video was not showing on the screen).
  3. UserA disabled video. Verified in the log that videoTileDidRemove was called for UserA's video.
  4. UserA enabled video again. Verified in the log that videoTileDidAdd was called again for UserA's video.

Manual test cases (add more as needed):

  • Join meeting without CallKit
  • Join meeting with CallKit as Incoming
  • Join meeting with CallKit as Outgoing
  • Leave meeting
  • Rejoin meeting
  • See metrics
  • See attendee presence
  • Send audio
  • Receive audio
  • Mute self
  • Unmute self
  • See local mute indicator when muted
  • See remote mute indicator when other is muted
  • Enable and disable local video
  • Enable and disable remote video from remote side
  • Send local video
  • Pause and resume remote video
  • Switch local camera
  • Receive remote screen share
  • Unit tests pass

Screenshots, if available:

N/A

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

hokyungh
hokyungh previously approved these changes Dec 4, 2020
@tianyux-amz tianyux-amz merged commit 76f597b into development Dec 7, 2020
@tianyux-amz tianyux-amz deleted the clear-video-tile-map branch December 7, 2020 18:51
zhinang-amazon pushed a commit that referenced this pull request Dec 14, 2020
…when video is unbound (#179)

* Remove the video tile mapping entry when video is removed instead of when video is unbound

* Address PR comments

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants