Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc #646

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Update doc #646

merged 1 commit into from
Feb 16, 2024

Conversation

dingyishen-amazon
Copy link
Contributor

@dingyishen-amazon dingyishen-amazon commented Feb 15, 2024

ℹ️ Description

provide a summary of the changes and the related issue, relevant motivation and context

Issue #, if available

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • README update
    • CHANGELOG update
    • guides update
  • This change requires a dependency update
    • Amazon Chime SDK Media
    • Other (update corresponding legal documents)

🧪 How Has This Been Tested?

describe the tests that you ran to verify your changes, any relevant details for your test configuration

Additional Manual Test

  • Pause and resume remote video
  • Switch local camera
  • Rotate screen back and forth

📱 Screenshots, if available

provide screenshots/video record if there's a UI change in demo app

✅ Checklist

Integration validation (required before release)

  • Unit tests pass
  • Build SDK against simulator with release options
  • Build SDK against device with release options
  • Build SDK against simulator with debug options
  • Build SDK against device with debug options
  • Test Demo against simulator with SDK (debug build) in workspace
  • Test Demo against device with SDK (debug build) in workspace
  • Test DemoObjC against simulator with SDK (debug build) in workspace
  • Test DemoObjC against device with SDK (debug build) in workspace
  • Test Demo against simulator with SDK.framework (release build)
  • Test Demo against device with SDK.framework (release build)
  • Test DemoObjC against simulator with SDK.framework (release build)
  • Test DemoObjC against device with SDK.framework (release build)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@@ -3,7 +3,7 @@
archiveVersion = 1;
classes = {
};
objectVersion = 52;
objectVersion = 54;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what caused this update? is it intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The objectVersion property in the project.pbxproj file specifies the version of the Xcode project file format. It is auto generated, and I think that is because my Xcode version is 15, but it did not lead to version incompatibility as the integration test build on Xode14 succeeded.

@dingyishen-amazon dingyishen-amazon merged commit 9a7acc8 into development Feb 16, 2024
3 of 4 checks passed
@dingyishen-amazon dingyishen-amazon deleted the doc-update branch February 16, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants