Skip to content

Commit

Permalink
Expose roundTripTime, jitter metric for audio and video stream(#2173)
Browse files Browse the repository at this point in the history
* Added rtt and uplink audio jitter to observable metrics

* Fix the incorrect calculation of aggregation WebRTC metric spec

Co-authored-by: Sichao Xue <[email protected]>
  • Loading branch information
LeviSklaroff and xuesichao authored Apr 27, 2022
1 parent e47bbbd commit 5009e6e
Show file tree
Hide file tree
Showing 6 changed files with 4,112 additions and 3,635 deletions.
9 changes: 6 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- Add `audioUpstreamRoundTripTimeMs`, `audioUpstreamJitterMs`, and `audioDownstreamJitterMs` to `observableMetricSpec`.
- Add `videoUpstreamRoundTripTimeMs`, `videoUpstreamJitterMs`, and `videoDownstreamJitterMs`, and `videoDownstreamDelayMs` to `observableVideoMetricSpec`.

### Removed

- No longer stop video stream when calling `stopLocalVideoTile`. This was added as a workaround to prevent crash in old Safari versions but no longer needed.

### Changed

- Subscribe and unsubscribe to `MediaStreamBrokerObserver` in `AudioVideoController` at the end of every connection and
disconnection to avoid trying to replace local audio and video during connection.
- Subscribe and unsubscribe to `MediaStreamBrokerObserver` in `AudioVideoController` at the end of every connection and disconnection to avoid trying to replace local audio and video during connection.
- Update `getMediaType` method to check the property `kind` instead of `mediaType` of a `RawMetricReport`.

### Fixed

- `MessagingSession` reconnects with refreshed endpoint and credentials if needed. EndpointUrl on `MessagingSessionConfiguration` is deprecated as it is resolved by calling `getMessagingSessionEndpoint` internally.
- `MessagingSession` reconnects with refreshed endpoint and credentials if needed. EndpointUrl on `MessagingSessionConfiguration` is deprecated as it is resolved by calling `getMessagingSessionEndpoint` internally.
- Fix a bug that `remote-inbound-rtp` `RTCStatsReport` and `remote-outbound-rtp` `RTCStatsReport` of "video" `kind` are accidentally filtered.
- Fix the incorrect calculation of aggregation WebRTC metric spec (`audioSpeakerDelayMs`, `decoderLoss`).

## [3.0.0] - 2022-03-30

Expand Down
5 changes: 4 additions & 1 deletion demos/browser/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5009e6e

Please sign in to comment.