-
Notifications
You must be signed in to change notification settings - Fork 477
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Clear srcObject in unbindVideoElement API * Cover POSTLogger unload event code path in unit test * Update unbindVideoElement documentation * Add control flag for the srcObject clearing - Update the unbindVideoElement API to take `cleanUpVideoElement` as an optional parameter with default set to true. - When cleanUpVideoElement is true, bounded video element's srcObject is set to null. This helps in memory leaks. The stream wont remain bound to the video element once unbound. - When cleanUpVideoElement is false, the stream remains bound to the video element once unbound. - Since, this is a change in behavior the control flag is added. - Update documentation to match v3 for some methods. - Add corresponding unit tests. * Update AudioVideoFacade - Update docs. - Tested in video_test app. - Updated unit tests. * Address feedback on documentation * Address unbindVideoElement feedback
- Loading branch information
1 parent
c9d8954
commit b7d2c31
Showing
19 changed files
with
174 additions
and
100 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.