Bug/msg session reconnect #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpwspoon
commented
Apr 29, 2022
| .promise(); | ||
| endpointUrl = endpoint.Endpoint.Url; | ||
| } catch (e) { | ||
| const closeEvent = new CloseEvent('close', { |
There was a problem hiding this comment.
Could you print the error here before creating the CloseEvent?
this.logger.error(${error});
There was a problem hiding this comment.
This is already logged when handled in the closeEventHandler
this.logger.info(`WebSocket close: ${event.code} ${event.reason}`);
so don't think duplicate logging is needed here:
There was a problem hiding this comment.
Yeah, but the reason is logged, not sure if error can be something different hence suggested.
There was a problem hiding this comment.
Also, good solution I think.
devalevenkatesh
approved these changes
May 3, 2022
devalevenkatesh
added a commit
that referenced
this pull request
May 3, 2022
* Messaging Session reconnects on failures to fetch messaging session endpoint Co-authored-by: David Witherspoon <[email protected]> Co-authored-by: Venkatesh Devale <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
Description of changes:
Fix issue with recent change to getMessagingSessionEndpoint resolve on connect where it would not reconnect if getMessagingSessionEndpoint failed.
Testing:
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Start the messaging demo app in browser. Create app instance user. Connect. Disconnect wifi, reconnect, and see websocket get establish
Checklist:
Have you successfully run
npm run build:releaselocally?yes
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
yes
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.