Add support background filter for ios 16+ #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltrung
force-pushed
the
background-filter-ios
branch
2 times, most recently
from
7f69440
to
4590a6e
Compare
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ### Added | |||
|
|
|||
| - Add the audio output gain and frequency to the meeting readiness checker's configuration. The readiness checker uses this value to set the "Play Tone" gain and frequency. | |||
| - Add support for background filter starting from iOS 16. | |||
There was a problem hiding this comment.
nit: Can update later but would be good to update the support documentation as well as include it as part of the CHANGELOG on which browsers we are adding support for.
| @@ -17,9 +17,10 @@ Background replacement is available as part of the Amazon Chime SDK for JavaScri | |||
|
|
|||
| ### Browser compatibility | |||
|
|
|||
| A background filter in the Amazon Chime SDK for JavaScript works in Firefox, Chrome, and Chromium-based browsers (including Electron) on desktop, Android, and Safari 14.1 and later on macOS. | |||
| A background filter in the Amazon Chime SDK for JavaScript works in Firefox, Chrome, and Chromium-based browsers | |||
There was a problem hiding this comment.
Should we call out the iPad firefox limitation here?
| @@ -66,6 +67,7 @@ describe('CleanStoppedSessionTask', () => { | |||
|
|
|||
| beforeEach(async () => { | |||
| domMockBuilder = new DOMMockBuilder(behavior); | |||
| browserBehavior = new DefaultBrowserBehavior(); | |||
There was a problem hiding this comment.
Should there be a afterEach to set the browserBehavior to undefined. Not sure if this will keep stale objects when running unit tests.
There was a problem hiding this comment.
Same for other tests included in this change.
There was a problem hiding this comment.
Don't think so as we initialize them every time to a new object. The old one should be garbage collected.
xuesichao
reviewed
Nov 2, 2022
xuesichao
reviewed
Nov 2, 2022
ltrung
force-pushed
the
background-filter-ios
branch
from
cec9f5e
to
c53e93f
Compare
xuesichao
approved these changes
Nov 2, 2022
devalevenkatesh
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1059:
Description of changes:
Add support background filter for ios 16+ in Safari, Chrome, and Firefox. The only exception is Firefox in iPad as we cannot detect os version from the user agent.
Testing:
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Yes, open serverless demo using Safari, Chrome, and Firefox (only on phone) in iPad and iPhone OS >= 16 and verify that you can see video filter drop down in the preview menu as well as during meeting.
Checklist:
Have you successfully run
npm run build:releaselocally? YesDo you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? No
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.