Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass the Capabilities for the global endpoint demo #2735

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

simmkyu
Copy link
Contributor

@simmkyu simmkyu commented Aug 19, 2023

Issue #:
N/A

Description of changes:

  • Do not pass the Capabilities for the global endpoint demo.

Testing:
N/A. Only a demo change

Can these tested using a demo application? Please provide reproducible step-by-step instructions.
In the demo application using the legacy Chime SDK global endpoint, the attendee capability feature should be unaffected. I've preserved the attendee capability UI for the global endpoint demo because we plan to deprecate the global endpoint soon.

Checklist:

  1. Have you successfully run npm run build:release locally?
    N/A

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
    No

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
    No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@simmkyu simmkyu requested a review from a team as a code owner August 19, 2023 02:28
@simmkyu simmkyu merged commit 2f5da80 into main Aug 19, 2023
10 checks passed
@simmkyu simmkyu deleted the do-not-pass-capabilities-for-global-endpoint branch August 19, 2023 02:34
simmkyu added a commit that referenced this pull request Aug 19, 2023
…and "Do not pass the Capabilities for the global endpoint demo (#2735)"
xuesichao pushed a commit that referenced this pull request Aug 19, 2023
…and "Do not pass the Capabilities for the global endpoint demo (#2735)" (#2736)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants