Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated function in build script #2755

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Remove deprecated function in build script #2755

merged 2 commits into from
Sep 12, 2023

Conversation

ltrung
Copy link
Contributor

@ltrung ltrung commented Sep 12, 2023

Description of changes:

  • Remove deprecated Ruby function exists in build script. This has been on the deprecated path since Ruby 2.5 and has been removed in Ruby 3.2 and later.
  • Update release script to only include relevant files to avoid accidentally include unwanted files.

Testing:

Can these tested using a demo application? Please provide reproducible step-by-step instructions.
N/A

Checklist:

  1. Have you successfully run npm run build:release locally? N/A

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? No

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ltrung ltrung requested a review from a team as a code owner September 12, 2023 02:07
@ltrung ltrung merged commit ea47044 into main Sep 12, 2023
10 checks passed
@ltrung ltrung deleted the fix-build-script branch September 12, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants