Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo] Replace AWS JS SDK v2 to v3 in demo and migrate from chime client sdk #2807

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

ltrung
Copy link
Contributor

@ltrung ltrung commented Nov 30, 2023

Issue #2697 :

Description of changes:

Testing:

Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Manually do regression testing with meeting, live transcription and media capture both in local and serverless demo. Will ask QA to verify before merging.

Checklist:

  1. Have you successfully run npm run build:release locally? Yes

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? No

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ltrung ltrung requested a review from a team as a code owner November 30, 2023 23:51
@ltrung ltrung changed the title Awssdkjsv3 Replace AWS JS SDK v2 to v3 in demo and migrate from chime client sdk Nov 30, 2023
michhyun1
michhyun1 previously approved these changes Dec 1, 2023
devalevenkatesh
devalevenkatesh previously approved these changes Dec 1, 2023
@ltrung ltrung dismissed stale reviews from devalevenkatesh and michhyun1 via 2ba5871 December 1, 2023 00:46
@ltrung ltrung changed the title Replace AWS JS SDK v2 to v3 in demo and migrate from chime client sdk [Demo] Replace AWS JS SDK v2 to v3 in demo and migrate from chime client sdk Dec 1, 2023
@ltrung ltrung merged commit e18a99a into main Dec 1, 2023
10 checks passed
@ltrung ltrung deleted the awssdkjsv3 branch December 1, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants