[WIP] Use dep #928
Closed
[WIP] Use dep #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating seelog and docker to make the dep migration work easier. "dep init" expects versions to be locked to git tags (or master).
Changing dependency manager to 'dep'. Dep will eventually be a part of the golang toolchain. This was done by running: ''' dep init rm -r agent/Godeps ''' More info: https://github.com/golang/dep
* Use older version of docker from our godep file (1.12.0-rc4) * Use actual git tags for gorilla/websocket and stretchr/testify
It looks like Gopkg.lock contains both: [[projects]]
name = "github.com/Sirupsen/logrus"
packages = ["."]
revision = "f006c2ac4710855cf0f916dd6b77acf6b048dc6e"
version = "v1.0.3"
# ...
[[projects]]
name = "github.com/sirupsen/logrus"
packages = ["."]
revision = "f006c2ac4710855cf0f916dd6b77acf6b048dc6e"
version = "v1.0.3"A number of projects have had issues with this, see sirupsen/logrus#570 (comment) for context. |
* Add override in go-ansiterm to ensure build
|
More errors in AppVeyor:
|
|
I think (at least some of) the issues you were having converting from Godep should be resolved with v0.3.1 (see golang/dep#924 for context). |
|
closing in favor of #1009 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use dep instead of godep.
Implementation details
See
agent/Gopkg.tomlandagent/Gopkg.lock.Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passLicensing
This contribution is under the terms of the Apache 2.0 License: yes