fix nil attachment for 1.5 release series #1000

jaypipes · 2020-05-28T15:01:18Z

This is a manual backport of the changes in
a139509 since there were so many
changes in the awsutils.go file since 1.5.7 that trying to resolve
conflicts was an exercise in futility.

Issue #914

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adding cn config as well (cherry picked from commit a55d865)

This is a manual backport of the changes in 5dfc31c since there were so many changes in the awsutils.go file since 1.5.7 that trying to resolve conflicts was an exercise in futility. Issue aws#914

mogren

LGTM, but should we merge this change into the release-1.5 branch instead?

anguslees and others added 6 commits April 2, 2020 16:35

Disable IPv6 RA and ICMP redirects on host-side veth

f88543c

Use -buildmode=pie for binaries

0920239

Export VERSION in Makefile

1f63a37

Update changelog and config

ec833bd

Update cni-metrics-helper config to correct apiVersion

f5705f7

Adding cn config as well (cherry picked from commit a55d865)

fix nil attachment for 1.5 release series

31603a8

This is a manual backport of the changes in 5dfc31c since there were so many changes in the awsutils.go file since 1.5.7 that trying to resolve conflicts was an exercise in futility. Issue aws#914

mogren reviewed May 28, 2020

View reviewed changes

jaypipes changed the base branch from release-1.5.7 to release-1.5 May 28, 2020 19:14

jaypipes closed this May 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix nil attachment for 1.5 release series #1000

fix nil attachment for 1.5 release series #1000

jaypipes commented May 28, 2020

mogren left a comment

fix nil attachment for 1.5 release series #1000

fix nil attachment for 1.5 release series #1000

Conversation

jaypipes commented May 28, 2020

mogren left a comment

Choose a reason for hiding this comment