-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/include snat cidrs #1229
Feat/include snat cidrs #1229
Conversation
@totahuanocotl I saw your PR #520, could you explain me how to handle rpc ? I'm missing something... |
It's been a year since that PR, and I haven't worked on the project since but I'll try to do my best. You will find how the cni plugin interacts with the ipam daemonset via grpc. The ipam daemonset sets up the host networking on startup, in our case we were interested in the iptables rules The plugin, on the other hand is what interacts with kubelet, and this will setup the ip routes in the host, which would be the NS for the pod, if it requires it. This interaction is the one done via grpc to the agent. Our interest was in the add command, since it is the one that sets up everything.
I hope this is enough to give you more clarity of how it fits together. |
This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days |
Pull request closed due to inactivity. |
What type of PR is this?
feature
Which issue does this PR fix:
#1224
What does this PR do / Why do we need it:
#1224
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Testing done on v1.6.1 (backport)
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.