Replace DescribeNetworkInterfaces with paginated version #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anguslees
reviewed
Dec 15, 2020
anguslees
reviewed
Dec 15, 2020
anguslees
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This PR tends to solve a latency issue when IPAMD need cleanup big number of ENIs.
Which issue does this PR fix:
Paginate DecribeNetworkInterface call #1325
What does this PR do / Why do we need it:
Non-pagintaed EC2 could cause latency increase dramatically for some customer.
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Load tests were done.
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
NO
Does this change require updates to the CNI daemonset config files to work?:
NO
Does this PR introduce any user-facing change?:
NO
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.