aws-node does not perform ip unassignment properly #1344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes aws-node pod from aws-node daemonset does not perform unassignment of non-existing docker containers.
This commit marks IPAMKey data structures where ContainerID is empty as unassigned.
Example of ipamd output:
"192.168.9.204": {
"Address": "192.168.9.204",
"IPAMKey": {
"containerID": "d74e85090b40c25325b82289ad335287ab9467784ea4014052e49f3032c4e9e8",
"ifName": "unknown",
"networkName": "_migrated-from-cri"
},
"UnassignedTime": "0001-01-01T00:00:00Z"
},
"192.168.9.25": {
"Address": "192.168.9.25",
"IPAMKey": {
"containerID": "",
"ifName": "",
"networkName": ""
},
"UnassignedTime": "0001-01-01T00:00:00Z"
},
"192.168.9.46": {
"Address": "192.168.9.46",
"IPAMKey": {
"containerID": "",
"ifName": "",
"networkName": ""
},
"UnassignedTime": "0001-01-01T00:00:00Z"
},
Eventually we are facing situation when we have free IP addresses but because ipamd thinks it is still assigned we are not able to add new containers.
After we re-deploy aws-node daemonset everything is back to normal again for couple of days.
|
I am worried about counters such as: Please let me know if you foresee any issues with this change as i am not be able to see all of the consequences. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong assumptions were made.
Will open another PR to deal with this issue