Make error count granular #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achevuru
reviewed
Oct 1, 2021
achevuru
approved these changes
Oct 3, 2021
jayanthvn
added a commit
to jayanthvn/amazon-vpc-cni-k8s
that referenced
this pull request
Oct 3, 2021
* Make error count granular * minor nit
achevuru
pushed a commit
that referenced
this pull request
Oct 3, 2021
jayanthvn
added a commit
to jayanthvn/amazon-vpc-cni-k8s
that referenced
this pull request
Oct 11, 2021
* Make error count granular * minor nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug
Which issue does this PR fix:
Fixes #1636
What does this PR do / Why do we need it:
Currently we
awsAPIErrInc("GetMetadata", err)in a common function which fetches from IMDSGetMetadataWithContext. We query for prefixes and secondary IPs but with secondary IP mode get prefixes will return 404 which is expected but the common functions logs the events as an error. Instead moving the logic to make the error count more granular. With this PR we will know the exact field in IMDS which is causing the error rather than just getMetaData which isnt sufficient for debugging.If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Yes
No errors incrementing.
Automation added to e2e:
n/a
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
no
Does this change require updates to the CNI daemonset config files to work?:
no
Does this PR introduce any user-facing change?:
no
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.