Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-use logger instance (#2029) #2031

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Re-use logger instance (#2029) #2031

merged 1 commit into from
Jul 12, 2022

Conversation

vikasmb
Copy link
Contributor

@vikasmb vikasmb commented Jul 12, 2022

  • Re-use logger instance
  • Existing logger initialization constructed different logger
    instances upon call to Get() method.
  • Fixed the initialization logic to re-use the logger instance.
  • Added unit tests for logger initialization fix

Cherry-pick of PR #2029

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* Re-use logger instance

- Existing logger initialization constructed different logger
  instances upon call to Get() method.
- Fixed the initailiation logic to re-use the logger instance.

* Added unit tests for logger initialization fix
@vikasmb vikasmb requested a review from a team as a code owner July 12, 2022 23:07
@orsenthil orsenthil merged commit cbd10b2 into aws:release-1.11 Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants