Update Release Workflow #2251
Merged
Update Release Workflow #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orsenthil
reviewed
Feb 2, 2023
orsenthil
reviewed
Feb 2, 2023
jdn5126
force-pushed
the
master
branch
2 times, most recently
from
b4f9de5
to
445b22a
Compare
jayanthvn
reviewed
Feb 7, 2023
| @@ -28,7 +28,7 @@ rules: | |||
| - apiGroups: [""] | |||
| resources: | |||
| - nodes | |||
| verbs: ["list", "watch", "get"] | |||
| verbs: ["list", "watch", "get", "update"] | |||
There was a problem hiding this comment.
I assume this will be removed for 1.13.0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
enhancement
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
This PR updates the release workflow to run only for published releases. The workflow will check out the release tag and run
makecommands from that workspace.Changes to the release scripts are as follows:
make upload-resources-to-githubis removed. We do not need to upload release artifacts since chart is available oneks-chartsand manifest is available and updated in release branch.make generate-cni-yamlis updated to no longer generate release artifacts.make config-folder-syncis updated to only generate PR for master branch (not release branch).If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
N/A
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
N/A
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.