Fixing the log message to be meaningful #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayanthvn
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Update the debug log message.
What does this PR do / Why do we need it:
When CNI pod was launching on a non schedulable node, we were seeing this error message.
{"level":"debug","ts":"2023-01-23T03:13:23.608Z","caller":"ipamd/ipamd.go:660","msg":"AWS CNI is terminating, will not try to attach any new IPs or ENIs right now"}.This was confusing, we had to look in the code to understand this is because of node not schedulable in our case.
Updated the logic to log valid debug message when node is not schedulable.
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
{"level":"debug","ts":"2023-01-23T03:13:23.608Z","caller":"ipamd/ipamd.go:660","msg":"AWS CNI is terminating, will not try to attach any new IPs or ENIs right now"}.Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.