Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding feature flags to configmap charts #2715

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

haouc
Copy link
Contributor

@haouc haouc commented Dec 18, 2023

What type of PR is this?

Which issue does this PR fix:
This PR is adding support for new feature flags into helm charts

What does this PR do / Why do we need it:
We have enabled supported for multiple new features but the flags are still missing in helm.

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Installed the charts locally

% kk get cm amazon-vpc-cni -oyaml
apiVersion: v1
data:
  branch-eni-cooldown: "60"
  enable-network-policy-controller: "false"
  enable-windows-ipam: "false"
  enable-windows-prefix-delegation: "false"
  minimum-ip-target: "0"
  warm-ip-target: "0"
  warm-prefix-target: "0"
kind: ConfigMap
metadata:
  annotations:
    meta.helm.sh/release-name: aws-vpc-cni
    meta.helm.sh/release-namespace: kube-system
  creationTimestamp: "2023-12-18T20:37:12Z"
  labels:
    app.kubernetes.io/instance: aws-vpc-cni
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: aws-node
    app.kubernetes.io/version: v1.15.4
    helm.sh/chart: aws-vpc-cni-1.15.4
    k8s-app: aws-node
  name: amazon-vpc-cni
  namespace: kube-system
  resourceVersion: "1345600"
  uid: 1050d013-5ee9-4810-9e7c-2077645f1eea

Tested change default value:
Changed the cooldown window to 90s

apiVersion: v1
data:
  branch-eni-cooldown: "90"
  enable-network-policy-controller: "false"
  enable-windows-ipam: "false"
  enable-windows-prefix-delegation: "false"
  minimum-ip-target: "0"
  warm-ip-target: "0"
  warm-prefix-target: "0"
kind: ConfigMap

Will this PR introduce any new dependencies?:

no
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
no

Does this change require updates to the CNI daemonset config files to work?:

no
Does this PR introduce any user-facing change?:

yes


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haouc haouc requested a review from a team as a code owner December 18, 2023 20:59
@jdn5126 jdn5126 merged commit 224bcaa into aws:master Dec 18, 2023
6 checks passed
jchen6585 pushed a commit to jchen6585/amazon-vpc-cni-k8s that referenced this pull request Dec 21, 2023
jdn5126 pushed a commit to jdn5126/amazon-vpc-cni-k8s that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants