Use primary interface to add iptables for connmark entry #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed unit test. |
Currently iptables for CONNMARK entry always uses `eth0`, even though AWS EC2 instance does not always use eth0. This fix uses primary interface name which was discovered dynamically.
mogren
suggested changes
Jan 30, 2019
mogren
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently iptables for CONNMARK entry always uses
eth0, even thoughAWS EC2 instance does not always use eth0.
This fix uses primary interface name which was discovered dynamically.
Please also refer to #196
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.