Fixed typos in json types for ENIConfig #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogren
approved these changes
Apr 11, 2019
| SecurityGroups []string `json:"securitygroups"` | ||
| Subnet string `json: "subnet"` | ||
| SecurityGroups []string `json:"securityGroups"` | ||
| Subnet string `json:"subnet"` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR this is necessary in order for CNI Custom Networking to work in 1.4.
Description of changes:
With the new crd updates, json fields are case sensitive. A space turned
subnetto be capitalized, and the docs expectsecurityGroup. This resulted in the subnet and security groups not be found so the ENI wasn't created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.