Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for allocating ENIs, and cover the WARM_ENI_TARGET=0 case #587

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Add tests for allocating ENIs, and cover the WARM_ENI_TARGET=0 case #587

merged 1 commit into from
Aug 13, 2019

Conversation

mogren
Copy link
Contributor

@mogren mogren commented Aug 12, 2019

Description of changes:

  • Add unit tests for allocating ENIs.
  • Handle the WARM_ENI_TARGET=0 case.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mogren mogren requested a review from tiffanyfay August 12, 2019 23:58
@mogren mogren mentioned this pull request Aug 13, 2019
Closed
@mogren
Copy link
Contributor Author

mogren commented Aug 13, 2019

@tiffanyfay Added some more cases :)

@mogren mogren merged commit 3607b74 into aws:master Aug 13, 2019
@mogren mogren deleted the fix-0-warm-eni branch August 13, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiffanyfay tiffanyfay tiffanyfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mogren @tiffanyfay