Add support for m5n/m5dn/r5n instances #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @mogren |
jaypipes
approved these changes
Oct 14, 2019
Yeah, like an EC2 API that would give us this info.... |
mogren
suggested changes
Oct 14, 2019
Jeffwan
force-pushed
the
add_new_instance
branch
from
89f6e4d
to
4002a1e
Compare
|
For short term, maybe we can run some utility to parse page and auto generate a go file? Instead of adding instance types, we should generate full snapshot every time. |
|
@Jeffwan we do have a script like that already, but it needs some updates 🙂 |
mogren
approved these changes
Oct 15, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#653
This is a follow up PR of #656. I just notice there're few other instance releases together with r5dn. We should add support for them together.
Description of changes:
Add eni and maximum ips for m5n/m5dn/r5n instances
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.