Add run-integration-tests.sh script #698
Conversation
scripts/run-integration-tests.sh
Outdated
| make docker IMAGE=$IMAGE_NAME VERSION=$IMAGE_VERSION | ||
| docker push $IMAGE_NAME:$IMAGE_VERSION | ||
|
|
||
| sed -i'.bak' "s,602401143452.dkr.ecr.us-west-2.amazonaws.com/amazon-k8s-cni,$IMAGE_NAME," ./config/v1.5/aws-k8s-cni.yaml |
There was a problem hiding this comment.
Not sure if this works on linux
nckturner
force-pushed
the
integration
branch
from
f3e7557
to
e8a45ef
Compare
- Runs integration tests - Uses aws-k8s-tester - Adapted from CSI test script, there may still be some stuff in here that won't apply
nckturner
force-pushed
the
integration
branch
from
e8a45ef
to
fe63eb7
Compare
nckturner
force-pushed
the
integration
branch
2 times, most recently
from
1e52dad
to
11512e5
Compare
|
Updated the PR and addressed your comments @jaypipes |
|
Depends on: aws/aws-k8s-tester#62 |
| f = framework.NewDefaultFramework("cni-integration") | ||
|
|
||
| ginkgo.It("should enable pod-pod communication", func() { | ||
| serverPod := newTestPod() |
There was a problem hiding this comment.
I think you need to clean up this resource, no? Otherwise, pods will continue to build up on the test cluster until the cluster is destroyed.
There was a problem hiding this comment.
Added a clean up.
There was a problem hiding this comment.
Prefer to set DeleteNamespaceOnFailure https://github.com/kubernetes/kubernetes/blob/cf06a2efd6ec950dc6707b57cd55cb4f50d29f33/test/e2e/framework/test_context.go#L278 true.
There was a problem hiding this comment.
Prefer to set DeleteNamespaceOnFailure https://github.com/kubernetes/kubernetes/blob/cf06a2efd6ec950dc6707b57cd55cb4f50d29f33/test/e2e/framework/test_context.go#L278 true.
The problem with that is that you cannot diagnose something if a failure occurs.
nckturner
force-pushed
the
integration
branch
from
11512e5
to
9394228
Compare
- Fix env vars - Fix Deprovision command - Split test and cluster config into separate /tmp directories - combine cluster functions into lib/cluster.sh
nckturner
force-pushed
the
integration
branch
from
9394228
to
36a9b19
Compare
|
The aws-k8s-tester PR is merged, can you take another look @jaypipes? |
Build was failing, though it looks to be transient failure in getting go lint tool. I've restarted the build jobs and will approve once I see a green. |
nckturner
changed the title
|
did not review bash because I hate it, also hate that we are calling these "integration" when we're spinning up a kubernetes cluster and testing cni "end to end" :) |
| f = framework.NewDefaultFramework("cni-integration") | ||
|
|
||
| ginkgo.It("should enable pod-pod communication", func() { | ||
| serverPod := newTestPod() |
There was a problem hiding this comment.
Prefer to set DeleteNamespaceOnFailure https://github.com/kubernetes/kubernetes/blob/cf06a2efd6ec950dc6707b57cd55cb4f50d29f33/test/e2e/framework/test_context.go#L278 true.
The problem with that is that you cannot diagnose something if a failure occurs.
* Add run-integration-tests.sh script - Runs integration tests - Uses aws-k8s-tester - Adapted from CSI test script, there may still be some stuff in here that won't apply * Add node ping test and make ginkgo verbose * Remove kubectl exec test code * Fix test runner script - Fix env vars - Fix Deprovision command - Split test and cluster config into separate /tmp directories - combine cluster functions into lib/cluster.sh
* Add run-integration-tests.sh script - Runs integration tests - Uses aws-k8s-tester - Adapted from CSI test script, there may still be some stuff in here that won't apply * Add node ping test and make ginkgo verbose * Remove kubectl exec test code * Fix test runner script - Fix env vars - Fix Deprovision command - Split test and cluster config into separate /tmp directories - combine cluster functions into lib/cluster.sh
* Add run-integration-tests.sh script - Runs integration tests - Uses aws-k8s-tester - Adapted from CSI test script, there may still be some stuff in here that won't apply * Add node ping test and make ginkgo verbose * Remove kubectl exec test code * Fix test runner script - Fix env vars - Fix Deprovision command - Split test and cluster config into separate /tmp directories - combine cluster functions into lib/cluster.sh
* Add run-integration-tests.sh script - Runs integration tests - Uses aws-k8s-tester - Adapted from CSI test script, there may still be some stuff in here that won't apply * Add node ping test and make ginkgo verbose * Remove kubectl exec test code * Fix test runner script - Fix env vars - Fix Deprovision command - Split test and cluster config into separate /tmp directories - combine cluster functions into lib/cluster.sh
Issue #, if available:
#697
Description of changes:
that won't apply
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.