-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CRI to obtain pod sandbox IDs instead of Kubernetes API #714
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bb17215
Revert "fix: get container ID from kube rather than docker (#371)"
drakedevel 07bcce8
go mod tidy
drakedevel 31268c3
Add initial proof-of-concept implementation of CRI support.
drakedevel f5daa9e
Update CRI socket path to /var/run/cri.sock
drakedevel 91b0ec5
Filter ready sandboxes and abort if there's a pod UID conflict.
drakedevel e243d10
Revert "fix: get container ID from kube rather than docker (#371)"
drakedevel 4955f43
Address review comments, refactor to use pod sandbox nomenclature con…
drakedevel 93624f8
Bail if we can't retrieve local pod sandboxes on startup.
drakedevel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be nice to put a comment above this block that explains why you're doing this. Something like this might work...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do -- should hopefully be clearer once the sandbox rename is done, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth noting that this code was largely pre-existing -- I restored it in the first commit with a revert, and modified it to use the
cripackage instead ofdocker, but didn't otherwise touch it. (e.g. the TODO was there before).Added a comment and tidied up the other comment to be a bit clearer.