Use CRI to obtain pod sandbox IDs instead of Kubernetes API (#714) #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert "fix: get container ID from kube rather than docker (aws#371)" This reverts commit 14de538. * go mod tidy * Add initial proof-of-concept implementation of CRI support. * Update CRI socket path to /var/run/cri.sock * Filter ready sandboxes and abort if there's a pod UID conflict. * Revert "fix: get container ID from kube rather than docker (aws#371)" This reverts commit 14de538. * Address review comments, refactor to use pod sandbox nomenclature consistently. * Bail if we can't retrieve local pod sandboxes on startup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Cherry pick of PR #714 against the
release-1.6branch by @drakedevel back tomaster.This reverts commit 14de538.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.