Update RollingUpdate strategy to allow 10% unavailable #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogren
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Thanks @gavinbunney! Matching the kube-proxy setting makes sense to me.
jaypipes
approved these changes
Jan 29, 2020
mogren
pushed a commit
to mogren/amazon-vpc-cni-k8s
that referenced
this pull request
Jan 31, 2020
(cherry picked from commit 8a59da0)
jaypipes
pushed a commit
that referenced
this pull request
Jan 31, 2020
(cherry picked from commit 8a59da0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This updates the
RollingUpdatestrategy to allow more pods to update simultaneously. When updating a reasonably sized cluster (~400 nodes), having a single pod update at a time takes an extremely long time.The PR changes the update strategy to allow 10% unavailable. This aligns with the update strategy from kube-proxy (here)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.