Cleanup code autogen #863
Merged
Cleanup code autogen #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @anguslees! It seems like the generated files have some different formatting, that's why the build failed:
A |
Change mockgen invocation to execute the version of mockgen that matches the version we will compile against. (ie: Use `go run github.com/golang/mock/mockgen ...`)
Note order is important: we want to generate mocks based on the code that protoc generates.
Output from `make generate`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Refactor/cleanup only. Should have zero behavioural change.
Add a
make generatetarget that just runsgo generate.Autogenerate protobuf files (
rpc/rpc.pb.go). For reference, I used:Change mockgen invocation to execute the version of mockgen that
matches the version we will compile against.
(ie: Use
go run github.com/golang/mock/mockgen ...)Update to mockgen 1.4.1
Reviewer: I recommend reviewing this by individual commits. The last commit is the result of rerunning
make generate.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.