Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing permissions in typha-cpha sa (Calico) #892

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Add missing permissions in typha-cpha sa (Calico) #892

merged 1 commit into from
Apr 2, 2020

Conversation

marcincuber
Copy link
Contributor

Description of changes:

Add missing permission to Calico service account typha-cpha. Fixes permissions issues visible in calico-typha-horizontal-autoscaler pod logs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mogren mogren added the calico Calico integration issue label Apr 2, 2020
Copy link
Contributor

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcincuber , matches upstream configs, except that they don't have "extensions".

@marcincuber
Copy link
Contributor Author

marcincuber commented Apr 2, 2020

@mogren thanks for approving. extensions API is still commonly used for deployments and daemonsets. I try to keep up with updates and I switched to using apps/v1 while back. In this case you have to maintain permissions for both extensions and apps.

I can confirm that this calico config works with EKS 1.15

@mogren mogren merged commit 595d8ef into aws:master Apr 2, 2020
@marcincuber marcincuber deleted the fix/calico-permissions branch April 4, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calico Calico integration issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants