ensure non-nil Attachment in getENIAttachmentID #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Practice good code safety in the `EC2MetadataCache.getENIAttachmentID()` method by not assuming that either the `DescribeNetworkInterfacesOutput` struct's `NetworkInterfaces` field is not empty and that the first `NetworkInterface` struct that collection has a non-nil `Attachment` field. Fixes Issue aws#914 however note that with aws#909, the source code changed dramatically and this patch will need to be written differently for v1.5.x branches.
jaypipes
changed the title
mogren
approved these changes
Apr 17, 2020
| @@ -305,6 +305,68 @@ func TestAWSGetFreeDeviceNumberNoDevice(t *testing.T) { | |||
| assert.Error(t, err) | |||
| } | |||
|
|
|||
| func TestGetENIAttachmentID(t *testing.T) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Practice good code safety in the
EC2MetadataCache.getENIAttachmentID()methodby not assuming that either the
DescribeNetworkInterfacesOutputstruct's
NetworkInterfacesfield is not empty and that the firstNetworkInterfacestruct in that collection has a non-nilAttachmentfield.
Fixes Issue #914
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.