-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogenerate per-region YAML manifests from a common template #986
Conversation
Possible objections:
|
This is great. I really want to get away from the mess of having multiple CNI version config folders. It would be a lot better to have the current recommended version configs directly in /config. For the next release, we create a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me /config/next
feels a bit weird. How about nightly
? Or is latest
better, since that's kind of the default tag? This would work better for testing CNI updates as well.
This will make it a lot easier to keep these configs in sync. For example, #955 requires us to update the sample config to fully use it. It still works with the current config, but we want to enable the init container by default eventually.
Also, I think we should get rid of the readiness probe, it's just delaying the startup for no reason.
Sg. How do you want me to do this? One logical change per PR, or rip the band-aid off in one go? |
Autogenerate per-region manifests from a common template in order to prevent drift across versions. Also: Separate in-development (unreleased) manifest changes from the most recent release, by creating a `config/master` directory. The idea is that on each new vX.Y release, we: - copy the latest version of config/master to config/vX.Y - set version = `vX.Y` near top of vX.Y/manifests.jsonnet - re-run `make generate` I have confirmed (using a yaml diff tool) that the generated manifests are identical to latest config/v1.6, except for: - re-ordering of documents within the top-level YAML stream - re-ordering of container `env` array - "v1.6.1" docker tag (intentionally) replaced with "latest" (because this is config/master)
(Updated PR description to reflect config/next => config/master) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Default to testing upgrades to `config/master` manifests in `run-integration-tests.sh`. Follow-on to aws#986. Correct internal comment re starting version: we test upgrades from whatever version is installed by `eks create cluster`. Also: Switch to shell `${foo:=bar}` idiom to reduce duplication (and chance for typos) in `foo=${foo:-bar}`.
Default to testing upgrades to `config/master` manifests in `run-integration-tests.sh`. Follow-on to #986. Correct internal comment re starting version: we test upgrades from whatever version is installed by `eks create cluster`. Also: Switch to shell `${foo:=bar}` idiom to reduce duplication (and chance for typos) in `foo=${foo:-bar}`.
Default to testing upgrades to `config/master` manifests in `run-integration-tests.sh`. Follow-on to aws#986. Correct internal comment re starting version: we test upgrades from whatever version is installed by `eks create cluster`. Also: Switch to shell `${foo:=bar}` idiom to reduce duplication (and chance for typos) in `foo=${foo:-bar}`.
Autogenerate per-region manifests from a common template in order to
prevent drift across versions.
Also: Separate in-development (unreleased) manifest changes from the
most recent release, by creating a
config/master
directory. The ideais that on each new vX.Y release, we:
vX.Y
near top of vX.Y/manifests.jsonnetmake generate
I have confirmed (using a yaml diff tool) that the generated manifests
are identical to latest config/v1.6, except for:
env
arraythis is config/master)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.