Skip to content

Commit

Permalink
fix: never ignore publiclyAccessible if it has been set
Browse files Browse the repository at this point in the history
  • Loading branch information
juanheyns committed Nov 16, 2023
1 parent ca71980 commit 8ce964a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/aws-cdk-lib/aws-rds/lib/aurora-cluster-instance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -450,11 +450,11 @@ class AuroraClusterInstance extends Resource implements IAuroraClusterInstance {

const isOwnedResource = Resource.isOwnedResource(props.cluster);
let internetConnected;
let publiclyAccessible = props.publiclyAccessible;
let publiclyAccessible;
if (isOwnedResource) {
const ownedCluster = props.cluster as DatabaseCluster;
internetConnected = ownedCluster.vpc.selectSubnets(ownedCluster.vpcSubnets).internetConnectivityEstablished;
publiclyAccessible = ownedCluster.vpcSubnets && ownedCluster.vpcSubnets.subnetType === ec2.SubnetType.PUBLIC;
publiclyAccessible = props.publiclyAccessible ?? (ownedCluster.vpcSubnets && ownedCluster.vpcSubnets.subnetType === ec2.SubnetType.PUBLIC);
}

// Get the actual subnet objects so we can depend on internet connectivity.
Expand Down

0 comments on commit 8ce964a

Please sign in to comment.