Skip to content

Commit

Permalink
fix(aws-ec2): fix typo in resource identifier (#818)
Browse files Browse the repository at this point in the history
This will mutate deployed VPC resources, but I verified that the route table association can be replaced without the deployment getting stuck.

I did not verify it does not have on impact on availability for the duration.
  • Loading branch information
rix0rrr authored Oct 5, 2018
1 parent a67b2d9 commit bebfef0
Show file tree
Hide file tree
Showing 10 changed files with 41 additions and 41 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
]
}
},
"VPCPublicSubnet1RouteTableAssociatioin249B4093": {
"VPCPublicSubnet1RouteTableAssociation0B0896DC": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -126,7 +126,7 @@
]
}
},
"VPCPublicSubnet2RouteTableAssociatioin766225D7": {
"VPCPublicSubnet2RouteTableAssociation5A808732": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -206,7 +206,7 @@
]
}
},
"VPCPublicSubnet3RouteTableAssociatioinF4E24B3B": {
"VPCPublicSubnet3RouteTableAssociation427FE0C6": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -286,7 +286,7 @@
]
}
},
"VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {
"VPCPrivateSubnet1RouteTableAssociation347902D1": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -340,7 +340,7 @@
]
}
},
"VPCPrivateSubnet2RouteTableAssociatioinC31995B4": {
"VPCPrivateSubnet2RouteTableAssociation0C73D413": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -394,7 +394,7 @@
]
}
},
"VPCPrivateSubnet3RouteTableAssociatioin3B0B6B38": {
"VPCPrivateSubnet3RouteTableAssociationC28D144E": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
]
}
},
"VPCPublicSubnet1RouteTableAssociatioin249B4093": {
"VPCPublicSubnet1RouteTableAssociation0B0896DC": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -126,7 +126,7 @@
]
}
},
"VPCPublicSubnet2RouteTableAssociatioin766225D7": {
"VPCPublicSubnet2RouteTableAssociation5A808732": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -206,7 +206,7 @@
]
}
},
"VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {
"VPCPrivateSubnet1RouteTableAssociation347902D1": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -260,7 +260,7 @@
]
}
},
"VPCPrivateSubnet2RouteTableAssociatioinC31995B4": {
"VPCPrivateSubnet2RouteTableAssociation0C73D413": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-ec2/lib/vpc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ export class VpcSubnet extends VpcSubnetRef implements cdk.ITaggable {
this.routeTableId = table.ref;

// Associate the public route table for this subnet, to this subnet
const routeAssoc = new cloudformation.SubnetRouteTableAssociationResource(this, 'RouteTableAssociatioin', {
const routeAssoc = new cloudformation.SubnetRouteTableAssociationResource(this, 'RouteTableAssociation', {
subnetId: this.subnetId,
routeTableId: table.ref
});
Expand Down
12 changes: 6 additions & 6 deletions packages/@aws-cdk/aws-ec2/test/integ.vpc.expected.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
]
}
},
"MyVpcPublicSubnet1RouteTableAssociatioin3562612E": {
"MyVpcPublicSubnet1RouteTableAssociation2ECEE1CB": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -126,7 +126,7 @@
]
}
},
"MyVpcPublicSubnet2RouteTableAssociatioin8E74FB35": {
"MyVpcPublicSubnet2RouteTableAssociation227DE78D": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -206,7 +206,7 @@
]
}
},
"MyVpcPublicSubnet3RouteTableAssociatioinA3FD1B71": {
"MyVpcPublicSubnet3RouteTableAssociation5C27DDA4": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -286,7 +286,7 @@
]
}
},
"MyVpcPrivateSubnet1RouteTableAssociatioin90CF6BAB": {
"MyVpcPrivateSubnet1RouteTableAssociation56D38C7E": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -340,7 +340,7 @@
]
}
},
"MyVpcPrivateSubnet2RouteTableAssociatioin803693C0": {
"MyVpcPrivateSubnet2RouteTableAssociation86A610DA": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -394,7 +394,7 @@
]
}
},
"MyVpcPrivateSubnet3RouteTableAssociatioinFB4A6FE6": {
"MyVpcPrivateSubnet3RouteTableAssociationD951741C": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
]
}
},
"VPCPublicSubnet1RouteTableAssociatioin249B4093": {
"VPCPublicSubnet1RouteTableAssociation0B0896DC": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -126,7 +126,7 @@
]
}
},
"VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {
"VPCPrivateSubnet1RouteTableAssociation347902D1": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
]
}
},
"VPCPublicSubnet1RouteTableAssociatioin249B4093": {
"VPCPublicSubnet1RouteTableAssociation0B0896DC": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -126,7 +126,7 @@
]
}
},
"VPCPublicSubnet2RouteTableAssociatioin766225D7": {
"VPCPublicSubnet2RouteTableAssociation5A808732": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -206,7 +206,7 @@
]
}
},
"VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {
"VPCPrivateSubnet1RouteTableAssociation347902D1": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -260,7 +260,7 @@
]
}
},
"VPCPrivateSubnet2RouteTableAssociatioinC31995B4": {
"VPCPrivateSubnet2RouteTableAssociation0C73D413": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
]
}
},
"VPCPublicSubnet1RouteTableAssociatioin249B4093": {
"VPCPublicSubnet1RouteTableAssociation0B0896DC": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -126,7 +126,7 @@
]
}
},
"VPCPublicSubnet2RouteTableAssociatioin766225D7": {
"VPCPublicSubnet2RouteTableAssociation5A808732": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -206,7 +206,7 @@
]
}
},
"VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {
"VPCPrivateSubnet1RouteTableAssociation347902D1": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -260,7 +260,7 @@
]
}
},
"VPCPrivateSubnet2RouteTableAssociatioinC31995B4": {
"VPCPrivateSubnet2RouteTableAssociation0C73D413": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
]
}
},
"VPCPublicSubnet1RouteTableAssociatioin249B4093": {
"VPCPublicSubnet1RouteTableAssociation0B0896DC": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -126,7 +126,7 @@
]
}
},
"VPCPublicSubnet2RouteTableAssociatioin766225D7": {
"VPCPublicSubnet2RouteTableAssociation5A808732": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -206,7 +206,7 @@
]
}
},
"VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {
"VPCPrivateSubnet1RouteTableAssociation347902D1": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -260,7 +260,7 @@
]
}
},
"VPCPrivateSubnet2RouteTableAssociatioinC31995B4": {
"VPCPrivateSubnet2RouteTableAssociation0C73D413": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down
8 changes: 4 additions & 4 deletions packages/@aws-cdk/aws-rds/test/integ.cluster.expected.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
]
}
},
"VPCPublicSubnet1RouteTableAssociatioin249B4093": {
"VPCPublicSubnet1RouteTableAssociation0B0896DC": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -126,7 +126,7 @@
]
}
},
"VPCPublicSubnet2RouteTableAssociatioin766225D7": {
"VPCPublicSubnet2RouteTableAssociation5A808732": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -206,7 +206,7 @@
]
}
},
"VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {
"VPCPrivateSubnet1RouteTableAssociation347902D1": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -260,7 +260,7 @@
]
}
},
"VPCPrivateSubnet2RouteTableAssociatioinC31995B4": {
"VPCPrivateSubnet2RouteTableAssociation0C73D413": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down
12 changes: 6 additions & 6 deletions packages/@aws-cdk/aws-route53/test/integ.route53.expected.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
]
}
},
"VPCPublicSubnet1RouteTableAssociatioin249B4093": {
"VPCPublicSubnet1RouteTableAssociation0B0896DC": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -126,7 +126,7 @@
]
}
},
"VPCPublicSubnet2RouteTableAssociatioin766225D7": {
"VPCPublicSubnet2RouteTableAssociation5A808732": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -206,7 +206,7 @@
]
}
},
"VPCPublicSubnet3RouteTableAssociatioinF4E24B3B": {
"VPCPublicSubnet3RouteTableAssociation427FE0C6": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -286,7 +286,7 @@
]
}
},
"VPCPrivateSubnet1RouteTableAssociatioin77F7CA18": {
"VPCPrivateSubnet1RouteTableAssociation347902D1": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -340,7 +340,7 @@
]
}
},
"VPCPrivateSubnet2RouteTableAssociatioinC31995B4": {
"VPCPrivateSubnet2RouteTableAssociation0C73D413": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down Expand Up @@ -394,7 +394,7 @@
]
}
},
"VPCPrivateSubnet3RouteTableAssociatioin3B0B6B38": {
"VPCPrivateSubnet3RouteTableAssociationC28D144E": {
"Type": "AWS::EC2::SubnetRouteTableAssociation",
"Properties": {
"RouteTableId": {
Expand Down

0 comments on commit bebfef0

Please sign in to comment.