Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events-targets): Add DLQ support for SQS target #16417

Closed
draftbk opened this issue Sep 8, 2021 · 2 comments · Fixed by #16916
Closed

feat(events-targets): Add DLQ support for SQS target #16417

draftbk opened this issue Sep 8, 2021 · 2 comments · Fixed by #16916
Labels
@aws-cdk/aws-events-targets @aws-cdk/aws-sqs Related to Amazon Simple Queue Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@draftbk
Copy link

draftbk commented Sep 8, 2021

This is an available feature through the AWS Console already. And is supported in many other target but not SQS: #11612.

Use Case

Use monocdk/aws-events-targets to create DLQ for events-targets as SQS

Proposed Solution

import * as sqs from "@aws-cdk/aws-sqs";
import * as events from "@aws-cdk/aws-events";
import * as targets from "@aws-cdk/aws-events-targets";

const targetSQS = new sqs.Queue(this, 'targetSQS', {
  queueName: 'targetSQS',
});

const rule = new events.Rule(this, 'rule', {
  eventPattern: {
    source: ["aws.ec2"],
  },
});

const myDeadLetterQueue = new sqs.Queue(this, 'myDeadLetterQueue');

rule.addTarget(new targets.SqsQueue(targetSQS, {
  deadLetterQueue: myDeadLetterQueue
}));
@draftbk draftbk added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 8, 2021
@github-actions github-actions bot added @aws-cdk/aws-events-targets @aws-cdk/aws-sqs Related to Amazon Simple Queue Service labels Sep 8, 2021
@njlynch njlynch added effort/medium Medium work item – several days of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Sep 10, 2021
@njlynch njlynch removed their assignment Sep 10, 2021
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort p2 and removed p1 effort/medium Medium work item – several days of effort labels Oct 4, 2021
@rix0rrr rix0rrr removed their assignment Oct 4, 2021
@rix0rrr
Copy link
Contributor

rix0rrr commented Oct 4, 2021

This could easily be copy/pasted from other rule targets that do support DLQs.

@rix0rrr rix0rrr added p1 and removed p2 labels Oct 4, 2021
@mergify mergify bot closed this as completed in #16916 Oct 19, 2021
mergify bot pushed a commit that referenced this issue Oct 19, 2021
feat(events-targets): Add DLQ support for SQS target

closes #16417 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
feat(events-targets): Add DLQ support for SQS target

closes aws#16417 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-events-targets @aws-cdk/aws-sqs Related to Amazon Simple Queue Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants