Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-ecs-patterns): ApplicationLoadBalancedEc2ServiceProps is missing placement strategies #19225

Closed
1 of 2 tasks
IhnatKlimchuk opened this issue Mar 3, 2022 · 2 comments · Fixed by #19612
Closed
1 of 2 tasks
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@IhnatKlimchuk
Copy link
Contributor

Description

I created an ApplicationLoadBalancedEc2Service service. Unfortunately, I found that service was not balanced properly against availability zones and creating 3 out of 3 tasks in 1 AV, causing worst service availability in outage case.

Use Case

You need to create ApplicationLoadBalancedEc2Service with custom placement strategies.

Proposed Solution

Update ApplicationLoadBalancedEc2ServiceProps with ability to pass placementStrategies?: PlacementStrategy[]; to Ec2ServiceProps.

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@IhnatKlimchuk IhnatKlimchuk added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 3, 2022
@github-actions github-actions bot added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Mar 3, 2022
@peterwoodworth peterwoodworth added effort/medium Medium work item – several days of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Mar 9, 2022
@peterwoodworth
Copy link
Contributor

We accept contributions! Check out our contributing guide to get started

@mergify mergify bot closed this as completed in #19612 Mar 31, 2022
mergify bot pushed a commit that referenced this issue Mar 31, 2022
…y patterns (#19612)

I've added PlacementStrategy and PlacementConstraint to 
- ApplicationLoadBalancedEc2Service
- ApplicationMultipleTargetGroupsEc2Service
- NetworkLoadBalancedEc2Service
- NetworkMultipleTargetGroupsEc2Service
- QueueProcessingEc2Service

and pass it to AWS ECS related service.

fixes #19225

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

StevePotter pushed a commit to StevePotter/aws-cdk that referenced this issue Apr 27, 2022
…y patterns (aws#19612)

I've added PlacementStrategy and PlacementConstraint to 
- ApplicationLoadBalancedEc2Service
- ApplicationMultipleTargetGroupsEc2Service
- NetworkLoadBalancedEc2Service
- NetworkMultipleTargetGroupsEc2Service
- QueueProcessingEc2Service

and pass it to AWS ECS related service.

fixes aws#19225

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
3 participants