Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-lex): CloudWatch missing from TextLogDestinationProperty #19571

Closed
chokevin-aws opened this issue Mar 25, 2022 · 2 comments · Fixed by #19587
Closed

(aws-lex): CloudWatch missing from TextLogDestinationProperty #19571

chokevin-aws opened this issue Mar 25, 2022 · 2 comments · Fixed by #19587
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1

Comments

@chokevin-aws
Copy link

chokevin-aws commented Mar 25, 2022 •
edited by ryparker
Loading

The Problem

CloudWatch is missing from TextLogDestinationProperty.

  • In CFN doc: AWS::Lex::BotAlias TextLogDestination contains a property CloudWatch
  • In CDK doc: TextLogDestinationProperty turns out to be empty

I noticed that this inconsistency might be caused by a patch which removed the property CloudWatch from TestLogDestination.

Other Information

As part of the AWS::Lex::BotAlias field there seems to have been a patch in the past which removed the problematic TextLogDestinationProperty from a previous build. We should have made appropriate fixes to the documentation since then so we are requesting the removal of the patch found here

CDK CLI Version

2.17.0

Framework Version

No response

Node.js Version

No response

OS

No response

Language

Typescript, Python, .NET, Java, Go

Language Version

No response

Other information

No response
@chokevin-aws chokevin-aws added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Mar 25, 2022
@ryparker ryparker changed the title (aws_lex): TextLogSetting patch removal (aws-lex): CloudWatch missing from TextLogDestinationProperty Mar 25, 2022
@ryparker ryparker added bug This issue is a bug. p1 and removed guidance Question that needs advice or information. labels Mar 25, 2022
@peterwoodworth peterwoodworth mentioned this issue Mar 28, 2022
Merged
@peterwoodworth
Copy link
Contributor

PR has been linked to fix 🙂

@peterwoodworth peterwoodworth added in-progress This issue is being actively worked on. effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Mar 28, 2022
@mergify mergify bot closed this as completed in #19587 Mar 28, 2022
mergify bot pushed a commit that referenced this issue Mar 28, 2022
@rix0rrr
chore(cfnspec): reintroduce Lex 'CloudWatch' property (#19587)
b08cd3f 
Remove the patch at the request of the Lex team.

closes #19571 


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

StevePotter pushed a commit to StevePotter/aws-cdk that referenced this issue Apr 27, 2022
@rix0rrr
chore(cfnspec): reintroduce Lex 'CloudWatch' property (aws#19587)
e50fa6e 
Remove the patch at the request of the Lex team.

closes aws#19571 


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(cfnspec): reintroduce Lex 'CloudWatch' property aws/aws-cdk
4 participants
@NGL321 @ryparker @peterwoodworth @chokevin-aws