Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset uploadIfChanged only runs for files not for directories #1997

Closed
brad-jones opened this issue Mar 12, 2019 · 1 comment · Fixed by #2931 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Closed

Asset uploadIfChanged only runs for files not for directories #1997

brad-jones opened this issue Mar 12, 2019 · 1 comment · Fixed by #2931 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7

Comments

@brad-jones
Copy link

When using new AssetCode('/some/path'), a zip file is created using prepareZipAsset and then uploaded using prepareFileAsset which executes uploadIfChanged.

The problem is that the zip file obviously has some timestamp data (or similar) in it that changes the hash of the file. So on every single deployment, regardless of if the asset has actually changed or not, a new asset is uploaded.

prepareZipAsset should either produce a idempot zip file or it should run a similar zipIfChanged function.

Anyway my workaround for now has been to use https://github.com/aws/aws-lambda-go/blob/master/cmd/build-lambda-zip/main.go to generate the zip of my lambdas and then get CDK to just upload the zip.

FYI: build-lambda-zip does produce an idempot zip file.
@spg
Copy link
Contributor

spg commented Jun 5, 2019

It seems like it's linked to the order of the files in the zip file (not the timestamps of the files themselves) #2759

jogold added a commit to jogold/aws-cdk that referenced this issue Jun 19, 2019
@jogold
feat(toolkit): ensure consistent zip files
6469782 
Zip files were not consistent across deploys resulting in unnecessary S3 uploads and stack updates.

Ensure consistency by appending files in series (guarantees file ordering in the zip) and reseting
dates (guarantess same hash for same content).

Closes aws#1997, Closes aws#2759
jogold added a commit to jogold/aws-cdk that referenced this issue Jun 19, 2019
@jogold
feat(toolkit): ensure consistent zip files
5056d4c 
Zip files were not consistent across deploys resulting in unnecessary S3 uploads and stack updates.

Ensure consistency by appending files in series (guarantees file ordering in the zip) and reseting
dates (guarantees same hash for same content).

Closes aws#1997, Closes aws#2759
@jogold jogold mentioned this issue Jun 19, 2019
Merged
4 tasks
rix0rrr pushed a commit that referenced this issue Jun 21, 2019
@jogold @rix0rrr
fix(toolkit): ensure asset zips are consistently produced (#2931)
9101161 
Zip files were not consistent across deploys resulting in unnecessary S3 uploads and stack updates.

Ensure consistency by appending files in series (guarantees file ordering in the zip) and reseting
dates (guarantees same hash for same content).

Closes #1997, Closes #2759
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 20, 2020
Closed
Closed
This was referenced Sep 24, 2024
Open
Open
Open
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
Open
@NOUIY NOUIY mentioned this issue Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(toolkit): ensure consistent zip files jogold/aws-cdk
[Snyk] Upgrade @aws-cdk/aws-iam from 0.22.0 to 0.39.0 MechanicalRock/tech-radar
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-s3 from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-cloudfront from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codecommit from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-cloudformation from 0.0.0 to 0.39.0 NOUIY/aws-solutions-constructs
2 participants
@spg @brad-jones