-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-cdk-eks: stack fails and corrupts after upgrade to v2.35 due to EKS logging config change #21515
Comments
possible fix from an AWS consultant:
|
I am facing the same error messages when upgrading > 2.34 in Typescript. This includes 2.37.0. The fix that @juweeks Posted worked for me, but I went back to 2.34.0, and everything ran fine again. |
…bled" (#21545) Reverts #21185 and #21463 Closes #21515 Re-opens #19898. Fix for this in progress. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
…bled" (#21545) Reverts #21185 and #21463 Closes #21515 Re-opens #19898. Fix for this in progress. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
If stuck with |
…bled" (aws#21545) Reverts aws#21185 and aws#21463 Closes aws#21515 Re-opens aws#19898. Fix for this in progress. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Describe the bug
Upgrading to v2.35 (from v2.33) and deploying (just the upgrade- no other code difference) to an existing EKS cluster pushes what appears to be a change in logging configuration to the stack.
Not only does the stack fail to deploy, but the nested stack fails to rollback, staying in
UPDATE_ROLLBACK_COMPLETE_CLEANUP_IN_PROGRESS
state and failing the parent stack rollback. The only way to remediate is to delete the OnEventHandler and IsCompleteHandler resources, thereby corrupting the entire thing.Expected Behavior
a stack that doesn't blow up
Current Behavior
cdk diff
on EKS stack after upgrading to v2.35:This results in a deploy failure in the ClusterResourceProviderNestedStack in the OnEventHandler custom resource:
Full diff for reference:
Reproduction Steps
cdk diff
-> no changescdk diff
-> see changescdk deploy
stack on v2.35Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.35.0 (build 5c23578)
Framework Version
2.35.0
Node.js Version
v16.15.1
OS
mac 12.4
Language
Python
Language Version
3.8.9
Other information
No response
The text was updated successfully, but these errors were encountered: