Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@aws-cdk-lib/aws-codepipeline-actions: KMS encryption key needed for S3DeployAction #24535

Closed
1 of 2 tasks
hussainak opened this issue Mar 9, 2023 · 2 comments · Fixed by #24536
Closed
1 of 2 tasks

@aws-cdk-lib/aws-codepipeline-actions: KMS encryption key needed for S3DeployAction #24535

hussainak opened this issue Mar 9, 2023 · 2 comments · Fixed by #24536
Labels
@aws-cdk/aws-codepipeline-actions effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@hussainak
Copy link
Contributor

Describe the feature

KMS Encryption key is used by S3 buckets and looks like it is missing from the CDK S3DeployAction

Use Case

I am always frustrated when CDK features do not match Cloud Formation templated features.

Proposed Solution

Add KMSEncryptionKeyARN in S3DeployAction

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.67.0

Environment details (OS name and version, etc.)

macOS Ventura 13.2.1
@hussainak hussainak added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 9, 2023
@hussainak hussainak mentioned this issue Mar 9, 2023
Merged
@pahud
Copy link
Contributor

pahud commented Mar 9, 2023

Thank you for your report and PR!

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Mar 9, 2023
@mergify mergify bot closed this as completed in #24536 May 18, 2023
mergify bot pushed a commit that referenced this issue May 18, 2023
@hussainak
feat(codepipeline-actions): add KMSEncryptionKeyARN for S3DeployAction (
b60876f 
#24536)

Add KMSEncryptionKeyARN for S3DeployAction

Closes #24535.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-codepipeline-actions effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codepipeline-actions): add KMSEncryptionKeyARN for S3DeployAction hussainak/aws-cdk
2 participants
@pahud @hussainak