Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-cdk-lib.aws_rds: Cluster storage configuration #25629

Closed
2 tasks
ayush-shah-1501 opened this issue May 17, 2023 · 9 comments · Fixed by #25704
Closed
2 tasks

aws-cdk-lib.aws_rds: Cluster storage configuration #25629

ayush-shah-1501 opened this issue May 17, 2023 · 9 comments · Fixed by #25704
Labels
aws-cdk-lib Related to the aws-cdk-lib package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@ayush-shah-1501
Copy link
Contributor

Describe the feature

AWS announced a new feature called Cluster Storage Configuration in Aurora for I/O intensive applications, where customers can choose between Aurora Standard and Aurora I/O Optimized configuration options.

image

Use Case

We created our Aurora database using CDK in Python, and now we want to move our Aurora database from Aurora Standard to Aurora I/O Optimized. However, in CDK, I can't find any configuration as AWS announced this in May 2023.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.79.1

Environment details (OS name and version, etc.)

Ubuntu

@ayush-shah-1501 ayush-shah-1501 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 17, 2023
@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label May 17, 2023
@khushail khushail self-assigned this May 18, 2023
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels May 18, 2023
@khushail khushail removed their assignment May 18, 2023
@khushail khushail added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 18, 2023
@khushail
Copy link
Contributor

Thanks @ayush-shah-1501 for submitting this feature request. CDK Team works on providing the support for various latest features and updates, and this should be on their chart as well. However I am not in a position to say when it would be available. However if you would like to work on this contribution, you could start with contributing guide and our team would be happy to review the PR.

@OperationalFallacy
Copy link

Subscribe

@Zishanwang1992
Copy link
Contributor

The solution seems straight forward. It can be supported by add field StorageType for "AWS::RDS::DBCluster". Here is the code to support field StorageEncrypted.

Not sure if anyone is already working on this. I would like to work on this feature if not yet.

@Zishanwang1992
Copy link
Contributor

Zishanwang1992 commented May 23, 2023

It looks like it is more complex than I thought after some implementation. The field Iops also needs to be supported if we are going to support new StorageType. I will add both field Iops and StorageType.

@OperationalFallacy
Copy link

@Zishanwang1992 are you talking about L1 or L2 constructs? If Cloudformation supports it, cdk users should be able to get this features.

@Zishanwang1992
Copy link
Contributor

@OperationalFallacy I am not familiar with the L1 or L2 constructs here. I assume you are mentioning CDK V1 and CDK V2 here. I agree with you that if CloudFormation supports the feature, the CDK users should be able to get the feature. But the current process seems to be separated, the CloudFormation might launch new resources or fields, but CDK will follow up to add support. Here is the CDK doc about the db cluster. It does not have the support for Aurora I/O Optimized(StorageType).

I believe the time gap shall be the KPI for CDK team. And it shall be improved with streamlined process. This topic is out of the scope of this issue.

@OperationalFallacy
Copy link

Yes, sorry I assumed for some reason you familiar with CDK. There are two types of constructs (Typescript classes) that users can create resources. L1 type directly generated from Cloudformation (and it looks like fields supported already), and L2 with additional abstractions to define resource more easier with some helpers.

We're overwriting StorageType property and "aurora-iopt1" value in our cdk app, while CDK project adds it in proper way.

Thank you for looking into this!

@Zishanwang1992
Copy link
Contributor

@OperationalFallacy Thanks for the clarification. I get your point here. It makes sense to me. I can also find the CloudFormation stuff from the public doc. I think @ayush-shah-1501 shall be able to mitigate the issue with the L1.

I think we can still add support for L2 to make it easier for customer to use, but it is not high priority.

@mergify mergify bot closed this as completed in #25704 May 30, 2023
mergify bot pushed a commit that referenced this issue May 30, 2023
Closes #25629

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-cdk-lib Related to the aws-cdk-lib package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
4 participants