Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integ tests for cross-region read/write custom resource handlers #27069

Closed
MrArnoldPalmer opened this issue Sep 8, 2023 · 1 comment · Fixed by #27118
Closed

Add integ tests for cross-region read/write custom resource handlers #27069

MrArnoldPalmer opened this issue Sep 8, 2023 · 1 comment · Fixed by #27118
Assignees
@MrArnoldPalmer
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@MrArnoldPalmer
Copy link
Contributor

No description provided.

@MrArnoldPalmer MrArnoldPalmer self-assigned this Sep 8, 2023
@peterwoodworth peterwoodworth added p1 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. labels Sep 8, 2023
@MrArnoldPalmer MrArnoldPalmer mentioned this issue Sep 12, 2023
Merged
@mergify mergify bot closed this as completed in #27118 Sep 12, 2023
mergify bot pushed a commit that referenced this issue Sep 12, 2023
@MrArnoldPalmer
chore: add integ test for cross-region refs (#27118)
8c76349 
Adds integration test for using cross-region reference custom resource handlers. Currently cross region multi-stack tests in `IntegTest` are not super well supported so assertions aren't a great option but a successful stack deploy and delete does indicate success of the CRs currently.

Closes #27069

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

mikewrighton pushed a commit that referenced this issue Sep 14, 2023
@MrArnoldPalmer
chore: add integ test for cross-region refs (#27118)
9eb00b9 
Adds integration test for using cross-region reference custom resource handlers. Currently cross region multi-stack tests in `IntegTest` are not super well supported so assertions aren't a great option but a successful stack deploy and delete does indicate success of the CRs currently.

Closes #27069

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrArnoldPalmer MrArnoldPalmer

Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add integ test for cross-region refs aws/aws-cdk
2 participants
@MrArnoldPalmer @peterwoodworth