Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queue-base: JSDoc of QueueAttributes QueueURL point to falsy Documentation Location #28734

Closed
niko-achilles opened this issue Jan 16, 2024 · 2 comments · Fixed by #28827
Closed
Labels
@aws-cdk/aws-sqs Related to Amazon Simple Queue Service bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@niko-achilles
Copy link

Describe the bug

Queue Base exports the interface QueueAttributes .
The interface QueueAttributes defines the queueUrl property among other interface properties.
The QueueAttributes are documented in JSDoc annotation.
In the documentation about queueUrl property as JSDoc annotation, the bug is found.
The @see tag of JSDoc points to a falsy http documentation location.

Expected Behavior

The property queueUrl of the QueueAttributes interface is expected to be documented as JSDoc annotation correctly.

Current Behavior

Below the @see tag of JSDoc annotation for queueUrl as defined in the current code base.
The line of code in the repository is located here

export interface QueueAttributes {
 
...

  /**
   * The URL of the queue.
   * @see https://docs.aws.amazon.com/sdk-for-net/v2/developer-guide/QueueURL.html
   *
   * @default - 'https://sqs.<region-endpoint>/<account-ID>/<queue-name>'
   */
  readonly queueUrl?: string;

...
} 

Reproduction Steps

Visit
the lines of code in the current repository here

And use the http resource defined in the JSDoc @see tag, which navigates to the following http location

Possible Solution

2 possible solutions:

  1. The @see JSDoc tag should be removed
export interface QueueAttributes {
...

  /**
   * The URL of the queue.
   * 
   * @default - 'https://sqs.<region-endpoint>/<account-ID>/<queue-name>'
   */
  readonly queueUrl?: string;

...
}
  1. correct the @see tag of JSDoc to point to the following http location
export interface QueueAttributes {
...

  /**
   * The URL of the queue.
   * @see https://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_GetQueueUrl.html#SQS-GetQueueUrl-response-QueueUrl
   * 
   * @default - 'https://sqs.<region-endpoint>/<account-ID>/<queue-name>'
   */
  readonly queueUrl?: string;

...
}

### Additional Information/Context

_No response_

### CDK CLI Version

2.121.1 (build d86bb1a)

### Framework Version

_No response_

### Node.js Version

v20.11.0

### OS

ubuntu

### Language

TypeScript

### Language Version

_No response_

### Other information

_No response_
@niko-achilles niko-achilles added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 16, 2024
@github-actions github-actions bot added the @aws-cdk/aws-sqs Related to Amazon Simple Queue Service label Jan 16, 2024
@tim-finnigan tim-finnigan self-assigned this Jan 19, 2024
@tim-finnigan
Copy link

tim-finnigan commented Jan 19, 2024

Hi @niko-achilles thanks for catching this issue, it definitely looks like that URL should be removed or replaced. Looking at other examples of @see in the code, it seems like those often point to User/Developer Guides. I think this page/section might be the best place to pout here for an SQS Queue URL: https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-queue-message-identifiers.html#sqs-general-identifiers. But I'd be interested to hear the feedback of others as well. Please feel free to submit a PR for this if you are inclined.

@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 and removed needs-triage This issue or PR still needs to be triaged. investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jan 19, 2024
@tim-finnigan tim-finnigan removed their assignment Jan 19, 2024
@tim-finnigan tim-finnigan added the effort/small Small work item – less than a day of effort label Jan 19, 2024
@mergify mergify bot closed this as completed in #28827 Jan 23, 2024
mergify bot pushed a commit that referenced this issue Jan 23, 2024
The queueUrl attribute of QueueAttributes interface contains bad url redirection address. This pull request aims to update the @see redirect address in queueUrl attribute for the proper sqs developer guide link.

Closes #28734.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-sqs Related to Amazon Simple Queue Service bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants