Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoScalingGroup: DatapointsToAlarm property support for BasicStepScalingPolicyProps #28749

Closed
2 tasks
Daniel-ZA opened this issue Jan 18, 2024 · 2 comments · Fixed by #28792
Closed
2 tasks

AutoScalingGroup: DatapointsToAlarm property support for BasicStepScalingPolicyProps #28749

Daniel-ZA opened this issue Jan 18, 2024 · 2 comments · Fixed by #28792
Labels
@aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@Daniel-ZA
Copy link

Describe the feature

Currently, the scale_on_metric method for the AutoScalingGroup construct does not support explicitly specifying the DatapointsToAlarm property but supports setting EvaluationPeriods. The scale_on_metric implements BasicStepScalingPolicyProps. Hence support DatapointsToAlarm in BasicStepScalingPolicyProps interface.

Use Case

This feature would be helpful instead of having to use the workaround of Escape Hatches to modify the underlying DatapointsToAlarm property in the CloudWatch alarm generated.

Proposed Solution

Add property DatapointsToAlarm property for BasicStepScalingPolicyProps construct.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.114.1

Environment details (OS name and version, etc.)

Linux/Windows
@Daniel-ZA Daniel-ZA added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 18, 2024
@github-actions github-actions bot added the @aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling label Jan 18, 2024
@pahud
Copy link
Contributor

pahud commented Jan 19, 2024

Thank you for the feature request.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 19, 2024
@go-to-k go-to-k mentioned this issue Jan 20, 2024
Merged
mergify bot pushed a commit that referenced this issue Jan 23, 2024
@go-to-k
feat(autoscaling): datapointsToAlarm property for step scaling poli…
baf2bfb 
…cy (#28792)

This PR adds a property `datapointsToAlarm` for `StepScalingPolicy`.

Closes #28749.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@mergify mergify bot closed this as completed in #28792 Jan 23, 2024
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(autoscaling): datapointsToAlarm property for step scaling policy go-to-k/aws-cdk
2 participants
@pahud @Daniel-ZA